Update unstable log shrinking#462
Conversation
Signed-off-by: Mohanad <mohanadkhaled87@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MohanadKh03 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @MohanadKh03. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // TODO: revisit shrinking. Using len/cap wasn't useful since | ||
| // stableTo slices the entries. It might be better to shrink | ||
| // based on the actual size of the retained entries instead. | ||
| const lenMultiple = 2 |
There was a problem hiding this comment.
We don't have plan to spend too much effort to optimize this. Let's just keep it as simple as possible.
| // TODO: revisit shrinking. Using len/cap wasn't useful since | |
| // stableTo slices the entries. It might be better to shrink | |
| // based on the actual size of the retained entries instead. | |
| const lenMultiple = 2 |
2 participants
Resolves: #71